Skip to content

MainWindow: Throw an error dialog on failed login#335

Merged
tintou merged 7 commits intomasterfrom
throw-dialog-failed-login
Oct 9, 2019
Merged

MainWindow: Throw an error dialog on failed login#335
tintou merged 7 commits intomasterfrom
throw-dialog-failed-login

Conversation

@danirabbit
Copy link
Copy Markdown
Member

And make sure this method always results in clearing the connecting state

@Ericson2314
Copy link
Copy Markdown

It seems e.message isn't logged anywhere? I had a hard time debugging things and would prefer the dialog box in lieu of proper logging.

@danirabbit danirabbit requested a review from tintou October 8, 2019 21:11
@tintou tintou merged commit fe1b1ad into master Oct 9, 2019
@tintou tintou deleted the throw-dialog-failed-login branch October 9, 2019 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants